Back to top

GitHub

Subscribe to GitHub feed
Updated: 59 min 5 sec ago

brownag commented on issue ncss-tech/soilDB#126

Wed, 07/15/2020 - 19:12
brownag commented on issue ncss-tech/soilDB#126 Jul 15, 2020 brownag commented Jul 15, 2020

There are some known issues with Rcpp on R 4.0.0 @kevinwolz This link might be relevant https://www.gitmemory.com/issue/RcppCore/Rcpp/1100/652675461

brownag commented on issue ncss-tech/soilDB#126

Wed, 07/15/2020 - 18:35
brownag commented on issue ncss-tech/soilDB#126 Jul 15, 2020 brownag commented Jul 15, 2020

@dylanbeaudette @kevinwolz Restart your R session before installing from github -- the package is currently loaded in your session. This is a bypro…

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 09:03
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

The above is now fixed for horizonColorIndices.

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 09:01
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

I will use the draft PR request feature, and convert to full PR when ready, in the future. Once I move it over, I want you to look at it. I had oth…

brownag pushed to dtoptim in ncss-tech/aqp

Wed, 07/15/2020 - 08:55
brownag pushed to dtoptim in ncss-tech/aqp Jul 15, 2020 1 commit to dtoptim
  • b335569 fix horizonColorIndices; define .I locally in min/max

brownag pushed to dtoptim in ncss-tech/aqp

Wed, 07/15/2020 - 08:40
brownag pushed to dtoptim in ncss-tech/aqp Jul 15, 2020 1 commit to dtoptim
  • b84f2b1 fix horizonColorIndices; define .I locally in min/max

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 08:10
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

However, any potential conversion would happen internal to the object in e.g. horizons<- when the color indices were reinserted. The horizon slot s…

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 08:08
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

Crap I deleted my comment. Here is the issue. horizonColorIndices will actually break if the object in the SPC is a data.table. It is unambiguous u…

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 08:03
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

In that example, horizons<- handles it when merge horizonColorIndices back into the SPC horizonColorIndices is written in a way that is unambiguous. …

brownag pushed to dtoptim in ncss-tech/aqp

Wed, 07/15/2020 - 07:55
brownag pushed to dtoptim in ncss-tech/aqp Jul 15, 2020 1 commit to dtoptim
  • 7c93545 can we improve ordered factor ints [.coalesce.idx] w/ DT?

brownag pushed to master in ncss-tech/aqp

Wed, 07/15/2020 - 07:54
brownag pushed to master in ncss-tech/aqp Jul 15, 2020 1 commit to master

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 07:38
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

I was testing whether I could have it there. I do things in branches and undo them -- I try lots of things and break lots of things. But I think th…

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 07:37
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

This back and forth I did here is weird. I think I was having an unrelated error and tried fiddling with this and did not change it back. Thanks fo…

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 07:34
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

I think that any time you do anything that could possibly be misinterpreted by data.table you need to call the method that will ensure that the dat…

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 07:29
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

It is actually done down below

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 07:28
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

correct, because of the only modest improvement for data.table -- it is not outweighed by setting a key -- I don't think It was something like 5-6 …

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 07:27
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

I have no idea. The efficiency is about 2x better than tapply. I think I could possibly do it better with := but I really struggled to improve perf…

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 07:25
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

You cannot use a vector of column names in the j index in the same way that you can in a data.frame. It might "work" but not the same way -- often …

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 07:02
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

Its OK, i should have committed the changes I had on deck. I didn't think I had hit the review button, but was planning to.

brownag commented on pull request ncss-tech/aqp#155

Wed, 07/15/2020 - 01:33
brownag commented on pull request ncss-tech/aqp#155 Jul 15, 2020 brownag commented Jul 15, 2020

This branch has had its history rebased, FYI. Should have resulted in essentially the same working tree -- but some things were fixed, Some files y…

Pages